Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cocoapods-beta: 1.9.0.beta.1 -> 1.9.0.beta.2 #75841

Merged
merged 1 commit into from Jan 11, 2020
Merged

cocoapods-beta: 1.9.0.beta.1 -> 1.9.0.beta.2 #75841

merged 1 commit into from Jan 11, 2020

Conversation

lilyball
Copy link
Member

Motivation for this change

https://github.com/CocoaPods/CocoaPods/releases/tag/1.9.0.beta.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving solely on the fact that this is @lilyball and in my books that's more than good enough 👍

@aanderse aanderse merged commit 526aec7 into NixOS:master Jan 11, 2020
@lilyball lilyball deleted the cocoapods-beta branch January 11, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lilyball @aanderse