Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamecube-tools: fix build #73844

Merged
merged 1 commit into from Nov 24, 2019
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 21, 2019

Motivation for this change

GL/gl.h was removed from mesa package in #72999, needs to be
directly imported from libGL now

list of hydra builds possibly broken by the GL/gl.h removal: https://hydra.nixos.org/eval/1555741?filter=x86_64-linux&compare=1555703&full=1#tabs-now-fail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor Author

going to give this another 24 hours, then merge. The build is currently broken

@jonringer
Copy link
Contributor Author

git quite a bit more cleanup on the expression

GL/gl.h was removed from mesa package, needs to be
directly imported from libGL now
@jonringer jonringer merged commit c236ffe into NixOS:master Nov 24, 2019
@jonringer jonringer deleted the fix-gamecube-tools branch February 13, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants