Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpart0: fix build #68695

Closed
wants to merge 1 commit into from
Closed

nixpart0: fix build #68695

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 13, 2019

Motivation for this change

#68361

noticed that pykickstart was the same version that is in the python packages. Just used that, as it was tripping up on finding duplicates of a package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68695
1 package were build:
python27Packages.nixpart0

@aszlig
Copy link
Member

aszlig commented Sep 14, 2019

@jonringer: Note that the duplicates are intentional here because we want to make sure that we never upgrade these packages as it breaks the NixOps bootstrap process for the Hetzner backend. I know that ideally we want to switch to nixpart 1.0 without the monkey patching, but that's not ready yet.

@jonringer
Copy link
Contributor Author

ill fix it when i have more time

@domenkozar
Copy link
Member

fixed nixpart0 in master and 19.09

@domenkozar domenkozar closed this Nov 21, 2019
@jonringer jonringer deleted the fix-nixpart0 branch November 21, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants