Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.4.2 -> 12.4.3 #73857

Merged
merged 1 commit into from Nov 25, 2019
Merged

gitlab: 12.4.2 -> 12.4.3 #73857

merged 1 commit into from Nov 25, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2019 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @talyz @fpletz @globin @krav

talyz
talyz approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • Built with nix-review pr 73857
  • Tested a few things manually in local VM

@talyz
Copy link
Contributor

talyz commented Nov 22, 2019

cc @flokli

@flokli flokli merged commit e073489 into NixOS:master Nov 25, 2019
@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

backported to 19.09 in 105e528.

@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

Hm, it seems 12.5 was also released on Nov 22: https://about.gitlab.com/blog/2019/11/22/gitlab-12-5-released/

Anybody already on it? 😆

@talyz
Copy link
Contributor

talyz commented Nov 26, 2019

Oh, I'll get on it today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @flokli