Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] qt512.qtbase: add patch for CVE-2019-18281 #73805

Merged
merged 1 commit into from Nov 28, 2019
Merged

[r19.09] qt512.qtbase: add patch for CVE-2019-18281 #73805

merged 1 commit into from Nov 28, 2019

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

#73680

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @qknight @ttuegel @periklis @bkchr

@KamilaBorowska KamilaBorowska changed the title qt512.qtbase: add patch for CVE-2019-18281 [r19.09] qt512.qtbase: add patch for CVE-2019-18281 Nov 20, 2019
@d-goldin
Copy link
Contributor

d-goldin commented Nov 23, 2019 •
edited

LGTM. But would it maybe make sense to bump the version to 5.12.5 instead? The patch releases should be quite compatible and might fix some other minor issues (we already have that on master b3594de) and for 5.11 this was addressed via bumping the version too (2f5d37b).

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Nov 23, 2019 •
edited

Maybe. I have no idea how to bump the version however, and there is less risk of issues when applying the patch.

@d-goldin
Copy link
Contributor

Poke @globin @ckauhaus

@globin globin merged commit 00c2b2c into NixOS:staging-19.09 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @d-goldin @globin