nixos/lxd: add package options for LXC, LXD and ZFS #73902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstch
force-pushed
the
feature/lxd-package-config
branch
2 times, most recently
from
9206978
to
20d5889
Compare
|
The force-push was to fix some forgotten whitespace. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/85 |
pstch
force-pushed
the
feature/lxd-package-config
branch
2 times, most recently
from
19cf258
to
a6947b6
Compare
pstch
force-pushed
the
feature/lxd-package-config
branch
from
a6947b6
to
64dae58
Compare
Mic92
reviewed
Dec 23, 2019
pstch
force-pushed
the
feature/lxd-package-config
branch
from
64dae58
to
690fe66
Compare
Currently, LXD always use pkgs.zfs, even if boot.zfs.enableUnstable is set. This change provides the option to change the LXC, LXD and ZFS packages, and determines the default ZFS package based on zfs.enableUnstable.
pstch
force-pushed
the
feature/lxd-package-config
branch
from
690fe66
to
665d863
Compare
|
hmm, wouldn't it be better to use packageOverrides for something like this? maybe |
|
Should I remove the ZFS part of this PR so that we can merge the LXC/LXD options and handle ZFS in another PR ? |
|
I tried that, but it seems to cause infinite recursions in our nixos modules system. |
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 30, 2020
nixos/lxd: add package options for LXC, LXD and ZFS (cherry picked from commit 8a14852)
anna328p
pushed a commit
to anna328p/nixpkgs
that referenced
this pull request
Feb 2, 2020
nixos/lxd: add package options for LXC, LXD and ZFS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, LXD always use pkgs.zfs, even if boot.zfs.enableUnstable is set. This
change provides the option to change the LXC, LXD and ZFS packages, and
determines the default ZFS package based on zfs.enableUnstable.
Motivation for this change
I had to change the LXD package (to use LXD from
nixpkgs-unstable), and noticed it could not be changed invirtualisation/lxd.nix. I also noticed thatzfs.enableUnstablewas not taken into account for the ZFS dependency.Things done
Added options for the LXC, LXD and ZFS packages in the LXD configuration.
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @