[webnfc] Introduce NDEFRecordInit#id to support writing record id #20391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 22, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1928891
branch
from
3345f80
to
9acad6b
Compare
The plan is:
1. Introduces NDEFRecord{Init}#id and supports reading.
Already done by crrev.com/c/1861574.
2. Supports writing.
This CL is focused on impl in Blink, with the following CLs focused
on impl in Device Service.
crrev.com/c/1910906
crrev.com/c/1911385
crrev.com/c/1915940
crrev.com/c/1916261
3. Introduces NFCScanOptions#id and filters records by it when scanning.
4. Removes NDEFMessage{Init}#url and old impl of the author record.
The spec changes:
w3c/web-nfc#338
w3c/web-nfc#340
w3c/web-nfc#446
BUG=520391
Change-Id: Ie6f5b2978f78676c3aa607d09e7ffd5bbb5005d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928891
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#720792}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1928891
branch
from
9acad6b
to
fd0aa8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is:
Introduces NDEFRecord{Init}#id and supports reading.
Already done by crrev.com/c/1861574.
Supports writing.
This CL is focused on impl in Blink, with the following CLs focused
on impl in Device Service.
crrev.com/c/1910906
crrev.com/c/1911385
crrev.com/c/1915940
crrev.com/c/1916261
Introduces NFCScanOptions#id and filters records by it when scanning.
Removes NDEFMessage{Init}#url and old impl of the author record.
The spec changes:
w3c/web-nfc#338
w3c/web-nfc#340
w3c/web-nfc#446
BUG=520391
Change-Id: Ie6f5b2978f78676c3aa607d09e7ffd5bbb5005d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928891
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#720792}