Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner: 12.4.1 -> 12.5.0 #73864

Merged
merged 1 commit into from Nov 22, 2019
Merged

gitlab-runner: 12.4.1 -> 12.5.0 #73864

merged 1 commit into from Nov 22, 2019

Conversation

max-wittig
Copy link
Contributor

Motivation for this change

Update to latest version.

See: https://gitlab.com/gitlab-org/gitlab-runner/blob/v12.5.0/CHANGELOG.md

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bachp @zimbatm @globin

KamilaBorowska
KamilaBorowska approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@KamilaBorowska KamilaBorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program runs on NixOS.

@ofborg ofborg bot requested review from globin, zimbatm and ehmry November 21, 2019 13:32
@zimbatm zimbatm merged commit d940d24 into NixOS:master Nov 22, 2019
@max-wittig max-wittig deleted the patch-4 branch November 22, 2019 09:56
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@max-wittig @dtzWill
gitlab-runner: 12.4.1 -> 12.5.0 (NixOS#73864)
0af4423 
(cherry picked from commit d940d24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@globin globin Awaiting requested review from globin

@zimbatm zimbatm Awaiting requested review from zimbatm

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@max-wittig @bachp @KamilaBorowska @zimbatm