Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice: add dev output with headers #73848

Merged
merged 1 commit into from Nov 21, 2019
Merged

libreoffice: add dev output with headers #73848

merged 1 commit into from Nov 21, 2019

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Nov 21, 2019 •
edited

Simple change which adds dev output, where header files are copied during build.

Motivation for this change

I'm working on getting LibreOffice Online into NixOS and it needs LibreOffice's include/LibreOfficeKit directory available during build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c @peterhoeg

@ofborg ofborg bot requested a review from 7c6f434c November 21, 2019 02:43
@7c6f434c 7c6f434c merged commit 403b208 into NixOS:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @nixos-discourse @7c6f434c