Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the calling convention #2374

Merged
merged 8 commits into from
Dec 1, 2019
Merged

Conversation

eggrobin
Copy link
Member

Once this is merged, we should wait a bit to see whether there are performance changes just from the calling convention change, and then switch from passing quantities by const reference to passing them by copy in a separate pull request.

@pleroy pleroy added the LGTM label Dec 1, 2019
@pleroy pleroy merged commit 83feee0 into mockingbirdnest:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants