Add support for tuxedo-keyboard LED backlighting. #73885
Conversation
blanky0230
changed the title
| @@ -0,0 +1,32 @@ | |||
| { stdenv, fetchFromGitHub, kernel, kmod }: | |||
|
|
|||
| # TODO: look at the other kernel modules packages and see if you find improvements to do | |||
There was a problem hiding this comment.
That part at installPhase seems still a bit off. Creating a directory just to move some artefact away seems redundant. Maybe I could find some way to direclty output the module to $out/lib/modules/${kernel.modDirVersion}.
| @@ -944,6 +944,11 @@ | |||
| githubId = 5718007; | |||
| name = "Bastian Köcher"; | |||
| }; | |||
| blanky0230 = { | |||
| email = "blanky0230@gmail.com"; | |||
| github = "blanky0230"; | |||
There was a problem hiding this comment.
githubId missing, see top of this file
There was a problem hiding this comment.
Thanks! I wasn't aware that it now is required :)
| "tuxedo_keyboard.brightness=255" | ||
| "tuxedo_keyboard.color_left=0xff0a0a" | ||
| ]; | ||
| </option> |
There was a problem hiding this comment.
There's <programlisting></programlisting> to render multiple lines of code
There was a problem hiding this comment.
That's a good tip! :)
| There are several parameters you can change. It's best to check at the source code description which options are supported. | ||
| You can find all the supported parameters at: <link xlink:href="https://github.com/tuxedocomputers/tuxedo-keyboard#kernelparam" /> | ||
|
|
||
| In order to use the 'custom' lighting with the maximumg brightness and a color of '0xff0a0a' one would put pass <literal>boot.kernelParams</literal> like this: |
There was a problem hiding this comment.
Shouldn't these 'custom' ones be <literal>custom</literal>? Same for the hex value
There was a problem hiding this comment.
Good point. Makes it more readable in the HTML output.
ofborg
bot
added
8.has: package (new)
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 11-100
and removed
2.status: merge conflict
labels
|
ping @infinisil wdyt? Please let me know if there's something more to do here :) Thank you! |
blanky0230
changed the title
|
The merge commit should be removed from the history now |
Motivation for this change
Additional hardware-support for another hardware vendor.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @zimbatm I have some doubts whether this needs a module at all now, since most things I had to be "configurable" via the module might as well just be set by the user directly. wdyt?