Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unibilium: 2.0.0 -> 20190811 #73850

Merged
merged 1 commit into from Dec 28, 2019
Merged

unibilium: 2.0.0 -> 20190811 #73850

merged 1 commit into from Dec 28, 2019

Conversation

teto
Copy link
Member

@teto teto commented Nov 21, 2019 •
edited

Main maintainer doesn't answer. Neovim is now the upstream see
neovim/neovim#10302

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from pSub November 21, 2019 08:32
@yorickvP
Copy link
Contributor

yorickvP commented Dec 4, 2019

Please change the version attr as well. (Also, please edit the old version in the title to 2.0.0)

@teto teto changed the title unibilium: 0.2.0 -> 20190811 unibilium: 2.0.0 -> 20190811 Dec 5, 2019
@teto
Copy link
Member Author

teto commented Dec 5, 2019

sry. done.

@teto
unibilium: 2.0.0 -> 20190811
eab1f01 
Main maintainer doesn't answer. Neovim is now the upstream see
neovim/neovim#10302
@teto
Copy link
Member Author

teto commented Dec 28, 2019

I've been hacking on neovim with this for some time without any issue. Merging.

@teto teto merged commit a3a0f1f into NixOS:master Dec 28, 2019
@teto teto deleted the unibilium branch December 28, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @yorickvP