manylinux packages for Python #73866
Conversation
|
I think you need to also edit the interpreters so that they say they are "manylinux" compliant |
|
yes, that's a separate step. I'm still thinking about the interface. |
|
should we mark this as WIP then? |
|
No, I make that change separate as it would be a mass-rebuild. This is usable without anyway. |
|
Yea, that's fair |
pkgs/top-level/all-packages.nix
Outdated
| @@ -9181,6 +9181,8 @@ in | |||
| pypy27Packages = pypy27.pkgs; | |||
| pypy3Packages = pypy3.pkgs; | |||
|
|
|||
| manylinuxPackages = callPackage ./../development/interpreters/python/manylinux { }; | |||
There was a problem hiding this comment.
This is kind of confusing as a top-level attribute (as it's python specific, but seems like it could be something broader), I think the manylinux* builders should live alongside buildPythonPackages under pythonX.pkgs
I'm also in favor of them being renamed from manylinuxXXXXPackage to buildManylinuxXXXXPackage
There was a problem hiding this comment.
This is kind of confusing as a top-level attribute (as it's python specific, but seems like it could be something broader)
These are not Python libraries, but just lists of derivations. They are used with Python packages but are not Python-version specific. Having some kind of indicator that they are related to Python is not be a bad idea.
I'm also in favor of them being renamed from manylinuxXXXXPackage to buildManylinuxXXXXPackage
They are not build functions either. The lists are just that, lists, and the other ones are derivations but are not meant to be used; you do not want to patchelf libs via the symlink tree because you would retain too many dependencies that way.
Ideally every package set contains only derivations, not functions or anything else. We're far from there but its important to consider.
There was a problem hiding this comment.
hmmm, I abandon my renaming stance, but still think it should be moved to python.manylinuxPackages, or python.pkgs.manylinuxPackages
This adds three lists with manylinux dependencies as well as three packages that include all the manylinux dependencies.
|
@FRidh I have renamed |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/mach-nix-create-python-environments-quick-and-easy/6858/17 |
This adds three lists with manylinux dependencies as well as three
packages that include all the manylinux dependencies.
Motivation for this change
Thanks to @thomasjm for their work in #55812.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @jonringer @adisbladis @thomasjm