tensorman: init at 0.1.0 #73852
Merged
tensorman: init at 0.1.0 #73852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build tensorman |
Lassulus
reviewed
Nov 21, 2019
Comment on lines
7
to
15
| src = fetchFromGitHub { | ||
| owner = "pop-os"; | ||
| repo = "tensorman"; | ||
| rev = version; | ||
| sha256 = "0ywb53snvymmwh10hm6whckz7dwmpqa4rxiggd24y178jdfrm2ns"; | ||
| }; | ||
|
|
||
| buildInputs = [ pkgconfig openssl ]; | ||
| cargoSha256 = "1gh5w6zzrvjk60bqaf355fagijy723rvmqjh4laksd96pmzdfwn9"; |
There was a problem hiding this comment.
I think there is still a space of indentation missing
|
@GrahamcOfBorg build tensorman |
|
can you squash the last 2 commits and make the commit message say: |
|
the commit message needs to change. right now it says: |
|
fixed |
Lassulus
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Easy management of Tensorflow containers with Docker as the backend.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
@Lassulus
@mmahut
opening a new PR was just easier than rebasing. I hope you don't mind.
cc @