Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c64e17b68dee
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a47e80122608
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 1, 2019

  1. ec2/create-amis.sh: register root device as /dev/xvda

    For the case of blkfront drives, there appears to be no difference
    between /dev/sda1 and /dev/xvda: the drive always appears as the
    kernel device /dev/xvda.
    
    For the case of nvme drives, the root device typically appears as
    /dev/nvme0n1.  Amazon provides the 'ec2-utils' package for their first
    party linux ("Amazon Linux"), which configures udev to create symlinks
    from the provided name to the nvme device name. This name is
    communicated through nvme "Identify Controller" response, which can be
    inspected with:
    
      nvme id-ctrl --raw-binary /dev/nvme0n1 | cut -c3073-3104 | hexdump -C
    
    On Amazon Linux, where the device is attached as "/dev/xvda", this
    creates:
    
    - /dev/xvda  -> nvme0n1
    - /dev/xvda1 -> nvme0n1p1
    
    On NixOS where the device is attach as "/dev/sda1", this creates:
    
    - /dev/sda1  -> nvme0n1
    - /dev/sda11 -> nvme0n1p1
    
    This is odd, but not inherently a problem.
    
    NixOS unconditionally configures grub to install to `/dev/xvda`, which
    fails on an instance using nvme storage. With the root device name set
    to xvda, both blkfront and nvme drives are accessible as /dev/xvda,
    either directly or by symlink.
    thefloweringash committed Nov 1, 2019
    Copy the full SHA
    bd61216 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Merge pull request #67349 from thefloweringash/amazon-device-names

    ec2/create-amis.sh: register root device as /dev/xvda
    domenkozar committed Nov 21, 2019
    Copy the full SHA
    a47e801 View commit details
    Browse the repository at this point in the history