Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: add pry to the dependencies #73836

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Nov 20, 2019

This is required to run travis console but is not part of the upstream
dependency list. Upstream is also not compatible with pry 0.12+ and
breaks with this error uninitialized constant Pry::SIMPLE_PROMPT.

Fixes #73238

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This is required to run `travis console` but is not part of the upstream
dependency list. Upstream is also not compatible with pry 0.12+ and
breaks with this error `uninitialized constant Pry::SIMPLE_PROMPT`.

Fixes NixOS#73238
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[12 built, 22 copied (37.5 MiB), 10.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73836
1 package were built:
travis

@jonringer jonringer merged commit e18435d into NixOS:master Nov 20, 2019
@zimbatm zimbatm deleted the travis-with-pry branch November 21, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

travis: console command needs 'pry'
2 participants