zenpower: init at 0.1.5 #73814
Merged
zenpower: init at 0.1.5 #73814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Nov 24, 2019
There was a problem hiding this comment.
I got a few failures, not sure if you want to mark it broken for the incompatible kernel+hardening combinations:
[12 built (2 failed), 26 copied (2111.5 MiB), 956.3 MiB DL]
error: build of '/nix/store/zldz13zp5pwjdz00a17a7bnj5c3ihfra-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73814
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.zenpower linuxPackages_hardkernel_latest.zenpower
2 package failed to build:
linuxPackages_4_4.zenpower linuxPackages_4_9.zenpower
11 package were built:
linuxPackages-libre.zenpower linuxPackages.zenpower linuxPackages_4_14.zenpower linuxPackages_5_3.zenpower linuxPackages_hardened.zenpower linuxPackages_latest-libre.zenpower linuxPackages_latest_hardened.zenpower linuxPackages_latest_xen_dom0.zenpower linuxPackages_testing_bcachefs.zenpower linuxPackages_testing_hardened.zenpower linuxPackages_xen_dom0.zenpower
|
@jonringer Thanks. I've marked kernel versions below 4.14 as broken. |
jonringer
reviewed
Nov 27, 2019
|
@jonringer Fixed. |
|
What's the status here? Can this be merged? |
Br1ght0ne
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
diff LGTM
checked with nixpkgs-review
[13 built, 60 copied (1922.2 MiB), 866.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73814
5 package marked as broken and skipped:
linuxPackages_4_4.zenpower linuxPackages_4_9.zenpower linuxPackages_5_3.zenpower linuxPackages_hardkernel_4_14.zenpower linuxPackages_hardkernel_latest.zenpower
11 package built:
linuxPackages-libre.zenpower linuxPackages.zenpower linuxPackages_4_14.zenpower linuxPackages_5_4.zenpower linuxPackages_hardened.zenpower linuxPackages_latest-libre.zenpower linuxPackages_latest_hardened.zenpower linuxPackages_latest_xen_dom0.zenpower linuxPackages_testing_bcachefs.zenpower linuxPackages_testing_hardened.zenpower linuxPackages_xen_dom0.zenpower
cc @marsam for (possibly) merging. Thanks!
|
Thank you, sorry for the delay. |
|
@marsam No worries! And thanks, I'll keep that in mind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Linux kernel driver for reading temperature, voltage(SVI2), current(SVI2) and power(SVI2) for AMD Zen family CPUs.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)