Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.google_cloud_translate: 1.7.0 -> 2.0.0 #73894

Merged
merged 1 commit into from Nov 22, 2019
Merged

python3Packages.google_cloud_translate: 1.7.0 -> 2.0.0 #73894

merged 1 commit into from Nov 22, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 22, 2019 •
edited

Motivation for this change

package was bumped to a broken state, this bumps and fixes it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[3 built, 7 copied (2.6 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73894
2 package were built:
python37Packages.google_cloud_translate python38Packages.google_cloud_translate

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.google_cloud_translate python38Packages.google_cloud_translate

@jonringer
Copy link
Contributor Author

seeing as this is broken on master, I'll merge once ofborg finishes

@ofborg ofborg bot requested a review from costrouc November 22, 2019 02:27
@jonringer jonringer merged commit 1a68d93 into NixOS:master Nov 22, 2019
@jonringer jonringer deleted the bump-google-cloud-translate branch February 13, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer