Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.portalocker: 1.5.1 -> 1.5.2 #73893

Merged
merged 1 commit into from Nov 22, 2019
Merged

python3Packages.portalocker: 1.5.1 -> 1.5.2 #73893

merged 1 commit into from Nov 22, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 22, 2019 •
edited

Motivation for this change

wolph/portalocker#47 was merged which fixes builds using dev versions of setuptools

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

azure-cli-core is broken on master

[8 built (3 failed), 175 copied (179.8 MiB), 27.1 MiB DL]
error: build of '/nix/store/bmfbmrmyyfa647hds0pxpfdcv2dvq2ha-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73893
3 package failed to build:
python27Packages.azure-cli-core python37Packages.azure-cli-core python38Packages.azure-cli-core

9 package were built:
python27Packages.applicationinsights python27Packages.azure-cli-telemetry python27Packages.portalocker python37Packages.applicationinsights python37Packages.azure-cli-telemetry python37Packages.portalocker python38Packages.applicationinsights python38Packages.azure-cli-telemetry python38Packages.portalocker

@jonringer
Copy link
Contributor Author

seeing as build is currently broken, I will likely merge this once ofborg finishes

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.applicationinsights python27Packages.azure-cli-telemetry python27Packages.portalocker python37Packages.applicationinsights python37Packages.azure-cli-telemetry python37Packages.portalocker python38Packages.applicationinsights python38Packages.azure-cli-telemetry python38Packages.portalocker

@jonringer jonringer merged commit 4ebb855 into NixOS:master Nov 22, 2019
@jonringer jonringer deleted the bump-portalocker branch February 13, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer