Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
base: 5d78f993cea3
Choose a base ref
...
head repository: solvespace/solvespace
compare: 74aa80b645ea
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 22, 2019

  1. Fix misuse of glTexImage2D. 

    Per the OpenGL documentation:
> GL_INVALID_VALUE may be generated if level is greater than
> log2(max), where max is the returned value of GL_MAX_TEXTURE_SIZE.

Although we always passed `log2(max) + 1` as `level`, for some reason
none of the GL implementations we run on ever returned an error.
It also appears there is a bug in ANGLE that crashes the process
instead in this case if the C++ runtime performs bound checks on
vector::operator[]=.
    @whitequark
    whitequark committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    74aa80b View commit details
    Browse the repository at this point in the history