Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldns: 1.7.0 -> 1.7.1 #73797

Merged
merged 2 commits into from Nov 20, 2019
Merged

ldns: 1.7.0 -> 1.7.1 #73797

merged 2 commits into from Nov 20, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 20, 2019

Motivation for this change

https://www.nlnetlabs.nl/news/2019/Jul/26/ldns-1.7.1-released/

  • examples no longer can be configured separately,
    so build everything we want in a single go
    and sort into the appropriate outputs after.
  • libtool file doesn't seem to reference openssl at all
    so nothing to patch up there as we did previously.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
ldns: 1.7.0 -> 1.7.1
dc9e2c3 
https://www.nlnetlabs.nl/news/2019/Jul/26/ldns-1.7.1-released/

* examples no longer can be configured separately,
  so build everything we want in a single go
  and sort into the appropriate outputs after.
* libtool file doesn't seem to reference openssl at all
  so nothing to patch up there as we did previously.
@dtzWill
ldns: add myself as maintainer! :)
d9c19f4
@dtzWill
Copy link
Member Author

dtzWill commented Nov 20, 2019

(reviewers requested per github suggestion, FWIW and thank you :))

@vcunat
Copy link
Member

vcunat commented Nov 20, 2019

@GrahamcOfBorg build dnscrypt-proxy strongswan tlspool freeswitch

vcunat added a commit that referenced this pull request Nov 20, 2019
@vcunat
Merge #73797: ldns: 1.7.0 -> 1.7.1
39ecc2d
@vcunat vcunat merged commit d9c19f4 into NixOS:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@jgeerds jgeerds Awaiting requested review from jgeerds

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @vcunat