Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pijul: fix build #73796

Merged
merged 1 commit into from Nov 22, 2019
Merged

pijul: fix build #73796

merged 1 commit into from Nov 22, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 20, 2019

Motivation for this change

nettle-sys=1.0.1 requires the des-compat.h header, but it was removed in nettle 3.5.
Upstream issue https://nest.pijul.com/pijul_org/pijul/discussions/416
FIxes #73757
cc: @loewenheim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FlorentBecker

@ofborg ofborg bot requested a review from FlorentBecker November 20, 2019 03:56
@d-goldin
Copy link
Contributor

LGTM. Briefly tested it, seems to work fine.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pijul

jonringer
jonringer approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executable seems to work

[3 built, 1 copied (1.8 MiB), 1.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73796
1 package were built:
pijul

@jonringer jonringer merged commit 31a9f6a into NixOS:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FlorentBecker FlorentBecker Awaiting requested review from FlorentBecker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can’t install pijul
3 participants
@marsam @d-goldin @jonringer