Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops_1_15: init at 1.15.0 #73809

Merged
merged 1 commit into from Dec 3, 2019
Merged

kops_1_15: init at 1.15.0 #73809

merged 1 commit into from Dec 3, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Nov 20, 2019

Motivation for this change

New package version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm

@Mic92
Copy link
Member

Mic92 commented Nov 20, 2019

What is the policy for keeping old versions for this package?

@kampka
Copy link
Contributor Author

kampka commented Nov 20, 2019

What is the policy for keeping old versions for this package?

I don't think there is one yet.
Typically the idea is to not force people to upgrade production clusters whenever nixpkgs updates.
I think it's reasonable to adopt the k8s supported versions model here, which boils down to the lastest three minor versions.

That being said, I would keep the existing versions because 1.12 introduces a breaking change and upgrading from <1.12 to >1.12 is not really supported.

@kampka
Copy link
Contributor Author

kampka commented Nov 26, 2019

Weekly reminder that this still needs a review.

@kampka
Copy link
Contributor Author

kampka commented Dec 3, 2019

@Mic92 So how do we make progress here?
This seems like a simple version bump to me, I don't really get why this has to linger here for weeks.

@zimbatm @offlinehacker @ehmry

@zimbatm zimbatm merged commit a951af1 into NixOS:master Dec 3, 2019
@zimbatm
Copy link
Member

zimbatm commented Dec 3, 2019

let's cleanup the old versions later. Usually we keep the 3 latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @Mic92 @zimbatm