Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MediaCapabilities: spatialRendering decoding query #20362

Merged
merged 1 commit into from Dec 3, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 21, 2019

This CL allows for spatialRendering to be queried with
MediaCapabilities.decodingInfo() for clear and EME. Changes required to blink
and media were relatively small so they were combined into this CL. This CL
does not add the ability to render spatial audio.

This functionality is behind blink feature flag MediaCapabilitiesSpatialAudio.
Note that if the flag is disabled, querying for spatialRendering will return
supported because decodingInfo ignores extraneous parameters by design.

For the media implementation, AudioType was because spatialRendering is
strictly tied to the codec.

Bug: 1020943

Change-Id: I01c9853b88f72ae8cb6291f9ca49e1d82cb220d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928077
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Vi Nguyen <ving@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#721185}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This CL allows for spatialRendering to be queried with
MediaCapabilities.decodingInfo() for clear and EME. Changes required to blink
and media were relatively small so they were combined into this CL. This CL
does not add the ability to render spatial audio.

This functionality is behind blink feature flag MediaCapabilitiesSpatialAudio.
Note that if the flag is disabled, querying for spatialRendering will return
supported because decodingInfo ignores extraneous parameters by design.

For the media implementation, AudioType was because spatialRendering is
strictly tied to the codec.

Bug: 1020943

Change-Id: I01c9853b88f72ae8cb6291f9ca49e1d82cb220d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928077
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Vi Nguyen <ving@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#721185}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants