Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pydocstyle: 2.1.1 -> 4.0.1 #73889

Merged
merged 2 commits into from Nov 22, 2019
Merged

python3Packages.pydocstyle: 2.1.1 -> 4.0.1 #73889

merged 2 commits into from Nov 22, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 21, 2019 •
edited

Motivation for this change

noticed it was horribly out of date

froze 2.1.1 for python2, bumped python3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

python3.8 failures are due to python38Packages.rope being broken upstream.

[12 built (2 failed), 234 copied (399.1 MiB), 76.3 MiB DL]
error: build of '/nix/store/bbp1jd411v4yyszmk3ydk2k5bqj3v678-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73889
4 package failed to build:
python38Packages.pyls-black python38Packages.pyls-isort python38Packages.pyls-mypy python38Packages.python-language-server

13 package were built:
esphome esptool python37Packages.flake8-import-order python37Packages.pydocstyle python37Packages.pylama python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python38Packages.flake8-import-order python38Packages.pydocstyle python38Packages.pylama todoman

@jonringer jonringer changed the title Bump pydocstyle python3Packages.pydocstyle: 2.1.1 -> 4.0.1 Nov 21, 2019
@jonringer
Copy link
Contributor Author

created issue for rope to support python3.8 here: python-rope/rope#277

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build esphome esptool python37Packages.flake8-import-order python37Packages.pydocstyle python37Packages.pylama python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python38Packages.flake8-import-order python38Packages.pydocstyle python38Packages.pylama todoman

@jonringer jonringer merged commit 148e772 into NixOS:master Nov 22, 2019
@jonringer jonringer deleted the bump-pydocstyle branch February 12, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer