New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/switch-to-configuration: restart changed socket units #73871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also extend this to .socket
for user sessions?
This should help with #71095
It's not clear to me how this relates to #71095, but I think there's no need to extend scope. The fix already improves socket handling, any further improvements can be done with whoever does them later on :) |
This question was more of a in-context heads-up. Of course doesn't need to stall this PR :-)
#71095 changed .socket files for the systemd user session, and I assume those were not properly reloaded/restarted, causing some already running gpg-agents not finding pinentry anymore.
|
Previously, socket units wouldn't be restarted if they were changed. To restart the socket, the service the socket is attached to needs to be stopped first before the socket can be restarted.
5bce80e
to
89806e9
Compare
Unfortunately this causes severe regressions by restarting systemd services that should not be restarted, e.g. See #74626 for more details. |
Reverted in master until that's fixed. |
…proved-socket-handling2" This reverts commit 57961d2, reversing changes made to b04f913. (I.e. this reverts PR NixOS#141192.) While well-intended, this change does unfortunately introduce very serious regressions that are especially disruptive/noticeable on desktop systems (e.g. users of Sway will loose their graphical session when running "nixos-rebuild switch"). Therefore, this change has to be reverted ASAP instead of trying to fix it in "production". Note: An updated version should be extensively discussed, reviewed, and tested before re-landing this change as an earlier version also had to be reverted for the exact same issues [0]. Fix: NixOS#146727 [0]: NixOS#73871 (comment)
…d-socket-handling2" This reverts commit 57961d2, reversing changes made to b04f913. (I.e. this reverts PR #141192.) While well-intended, this change does unfortunately introduce very serious regressions that are especially disruptive/noticeable on desktop systems (e.g. users of Sway will loose their graphical session when running "nixos-rebuild switch"). Therefore, this change has to be reverted ASAP instead of trying to fix it in "production". Note: An updated version should be extensively discussed, reviewed, and tested before re-landing this change as an earlier version also had to be reverted for the exact same issues [0]. Fix: #146727 [0]: #73871 (comment) (cherry picked from commit 1cfecb6)
…proved-socket-handling2" This reverts commit 57961d2, reversing changes made to b04f913. (I.e. this reverts PR NixOS#141192.) While well-intended, this change does unfortunately introduce very serious regressions that are especially disruptive/noticeable on desktop systems (e.g. users of Sway will loose their graphical session when running "nixos-rebuild switch"). Therefore, this change has to be reverted ASAP instead of trying to fix it in "production". Note: An updated version should be extensively discussed, reviewed, and tested before re-landing this change as an earlier version also had to be reverted for the exact same issues [0]. Fix: NixOS#146727 [0]: NixOS#73871 (comment)
Motivation for this change
The bugfix part of #50340
Things done
cc author @fpletz