Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tensorflow-tensorboard: add wheel as runtime dep #73870

Closed
wants to merge 1 commit into from
Closed

python3Packages.tensorflow-tensorboard: add wheel as runtime dep #73870

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 21, 2019 •
edited

The cli requires the wheel package to determine
entry points for execution.

(cherry picked from commit 7d091ce)
Signed-off-by: Jonathan Ringer jonringer117@gmail.com

Motivation for this change

backport of #73842

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
python3Packages.tensorflow-tensorboard: add wheel as runtime dep
340d08f 
The cli requires the wheel package to determine
entry points for execution.

(cherry picked from commit 7d091ce)
Signed-off-by: Jonathan Ringer <jonringer117@gmail.com>
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.tensorflow-tensorboard pythonPackages.tensorflow-tensorboard

@ofborg ofborg bot requested a review from abbradar November 21, 2019 16:11
@jonringer
Copy link
Contributor Author

looks like i need to backport the bump as well for my changes to not be broken

@jonringer
Copy link
Contributor Author

no desire to figure out changeset needed for proper backport

@jonringer jonringer closed this Jan 9, 2020
@jonringer jonringer deleted the fix-tensorboard-stable branch January 9, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer