Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.LanguageClient-neovim: 0.1.154 -> 0.1.155 #73832

Merged
merged 1 commit into from Dec 10, 2019
Merged

vimPlugins.LanguageClient-neovim: 0.1.154 -> 0.1.155 #73832

merged 1 commit into from Dec 10, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

New version! \o/

https://github.com/autozimu/LanguageClient-neovim/releases/tag/0.1.155

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

No maintainer? 馃槩

@teto
Copy link
Member

teto commented Nov 21, 2019

wanna add yourself as a maintainer (note that neovim's master has its own LSP embedded now)

@minijackson
Copy link
Member Author

With neovim adding its own LSP support, I don't know if I'm going to keep on using LanguageClient (maybe, maybe not), so I don't want to get ahead of myself

@teto
Copy link
Member

teto commented Nov 21, 2019

@GrahamcOfBorg build vimPlugins.LanguageClient-neovim

1 similar comment
@teto
Copy link
Member

teto commented Nov 22, 2019

@GrahamcOfBorg build vimPlugins.LanguageClient-neovim

@minijackson
Copy link
Member Author

Up?

@teto teto merged commit 8797d4f into NixOS:master Dec 10, 2019
@teto
Copy link
Member

teto commented Dec 10, 2019

btw, I've been using neovim's native lsp and it really is great. On par with coc I would say (though less documented and still a moving target).

@minijackson
Copy link
Member Author

awesome, can't wait until it is released!

@minijackson minijackson deleted the LanguageClient-neovim-0.1.155 branch December 10, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minijackson @teto