Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-daemon: fix missing dependency #73897

Merged
merged 1 commit into from Nov 27, 2019
Merged

python3Packages.python-daemon: fix missing dependency #73897

merged 1 commit into from Nov 27, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 22, 2019 •
edited

Motivation for this change

noticed it was broken

added tests,
cleaned up arguments a bit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[2 built (1 failed), 6 copied (28.3 MiB), 4.0 MiB DL]
error: build of '/nix/store/awklcgykqpgcfr288235qilypgghxd2r-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73897
7 package are marked as broken and were skipped:
python27Packages.ansible-kernel python27Packages.ansible-runner python27Packages.coilmq python27Packages.ledger_agent python27Packages.libagent python27Packages.python-daemon python27Packages.salmon-mail

1 package failed to build:
python38Packages.salmon-mail

18 package were built:
apache-airflow evdevremapkeys keepkey_agent ledger_agent luigi python37Packages.ansible-kernel python37Packages.ansible-runner python37Packages.libagent python37Packages.python-daemon python37Packages.salmon-mail trezor_agent python38Packages.ansible-kernel python38Packages.ansible-runner python38Packages.keepkey_agent python38Packages.ledger_agent python38Packages.libagent python38Packages.python-daemon python38Packages.trezor_agent

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.python-daemon python38Packages.python-daemon

@jonringer
Copy link
Contributor Author

seeing as build is broken on master, merging if this is successful.

@jonringer jonringer merged commit 8d37779 into NixOS:master Nov 27, 2019
@jonringer jonringer deleted the fix-daemon branch November 27, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer