Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.* 2019.2.* -> 2019.3 #73879

Merged
merged 25 commits into from Dec 31, 2019
Merged

jetbrains.* 2019.2.* -> 2019.3 #73879

merged 25 commits into from Dec 31, 2019

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Nov 21, 2019 •
edited

Motivation for this change

Bugfix releases of jetbrains Ideas.

For me, Goland is broken in 2019.2.4. so I updated it to 2019.3. (I'm not sure if it is broken for everyone, it could be my specific combination of plugins). It works with 2019.3.

I've tested the execution of Goland, Phpstorm and clion.

IMHO, as Goland is broken, it should be backported to stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@liff
Copy link
Contributor

liff commented Dec 1, 2019

There’s 2019.3 release available for these (per running update.pl):

  • CLion
  • GoLand
  • Intellij IDEA
  • PhpStorm
  • RubyMine
  • WebStorm

@liff
Copy link
Contributor

liff commented Dec 1, 2019

If updating to 2019.3, perhaps update jetbrains-jdk as well? The JDK version bundled with idea-community for Linux looks to be 520.11.

@kolaente kolaente changed the title jetbrains.* 2019.2.4 -> 2019.2.5 jetbrains.* 2019.2.* -> 2019.3 Dec 2, 2019
@kolaente
Copy link
Member Author

kolaente commented Dec 2, 2019

@liff I've updated the IDE's to 2019.3

I'm not sure how to find the latest version of the jdk, simply putting 520.11 as version in

nixpkgs/pkgs/development/compilers/jetbrains-jdk/default.nix

Line 10 in dae3575

version = "164";
does not seem to work. Do you have an idea?

@liff
Copy link
Contributor

liff commented Dec 2, 2019

I found the jetbrains-jdk release files by stripping download_file from the bintray URLs in fetchurl. The files for the 520.11 release can be found under

For macOS the OpenJDK version has changed from 11.0.2 to 11.0.4 so the download URL for x86_64-darwin should be changed to:

https://bintray.com/jetbrains/intellij-jdk/download_file?file_path=jbrsdk-11_0_4-osx-x64-b${version}.tar.gz

You can get the sha256 values by running:

# Linux
nix-prefetch-url 'https://bintray.com/jetbrains/intellij-jbr/download_file?file_path=jbrsdk-11_0_4-linux-x64-b520.11.tar.gz'
# macOS
nix-prefetch-url 'https://bintray.com/jetbrains/intellij-jbr/download_file?file_path=jbrsdk-11_0_4-osx-x64-b520.11.tar.gz'

@liff
Copy link
Contributor

liff commented Dec 13, 2019

Noticed that the macOS bintray repository for JetBrains Runtime is currently intellij-jdk and not intellij-jbr as it should be.

See also: #75171

@pmiddend
Copy link
Contributor

Is there anything blocking this PR from being merged?

@sjfloat
Copy link
Contributor

sjfloat commented Dec 17, 2019

A review, apparently.

@kolaente
Copy link
Member Author

A new update was available for 2019.3.1, I updated.

@kolaente
Copy link
Member Author

@liff I would propose to move updating the jdk into a seperate PR, to get this one merged as fast as possible.

@liff
Copy link
Contributor

liff commented Dec 28, 2019

Sounds good to me. 2013.3.1 seems to ship with 520.17.

@kolaente kolaente mentioned this pull request Dec 28, 2019
Closed
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/100

Lassulus
Lassulus approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, sorry for the delay

@Lassulus Lassulus merged commit e4d0e33 into NixOS:master Dec 31, 2019
@kolaente
Copy link
Member Author

@Lassulus Thanks!

@kolaente kolaente deleted the update/jetbrains-2019.4 branch December 31, 2019 16:17
@jonringer
Copy link
Contributor

this commit history should have been cleaned up. Each package was bumped 3x

@jonringer jonringer mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kolaente @liff @pmiddend @sjfloat @nixos-discourse @jonringer @Lassulus