Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: enable some of broken tests #73861

Merged
merged 1 commit into from Dec 6, 2019
Merged

git: enable some of broken tests #73861

merged 1 commit into from Dec 6, 2019

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Nov 21, 2019 •
edited

Motivation for this change

Enabled tests because they could be enabled. I think we may want to do some sort of change in git anyway because of #73806, so rebuild is non-issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti @the-kenny @wmertens @globin

@FRidh
Copy link
Member

FRidh commented Nov 24, 2019

needs rebase

@FRidh FRidh added this to WIP in Staging Nov 24, 2019
@KamilaBorowska
Copy link
Member Author

Done.

@FRidh
Copy link
Member

FRidh commented Nov 24, 2019

rebase, don't merge.

@KamilaBorowska
Copy link
Member Author

Rebased.

@ofborg ofborg bot requested a review from wmertens November 24, 2019 10:11
@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Nov 24, 2019 •
edited

Hm, weird, build fails, but only on x86_64-linux. I guess there may be something non-deterministic then?

Although checking the result, the test that fails is t5319-multi-pack-index, so... I don't know, I did nothing about that one.

@KamilaBorowska
Copy link
Member Author

Rebased again due to another merge conflict.

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2019

@GrahamcOfBorg build git

@peti peti merged commit fa9159b into NixOS:staging Dec 6, 2019
Staging automation moved this from WIP to Done Dec 6, 2019
@bdesham bdesham mentioned this pull request Feb 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@globin globin Awaiting requested review from globin

@the-kenny the-kenny Awaiting requested review from the-kenny

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KamilaBorowska @FRidh @Mic92 @wmertens @peti