Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tnef: 1.4.17 -> 1.4.18, addressing CVE-2019-18849 #73882

Merged
merged 1 commit into from Nov 24, 2019
Merged

tnef: 1.4.17 -> 1.4.18, addressing CVE-2019-18849 #73882

merged 1 commit into from Nov 24, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 21, 2019 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-18849

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from peterhoeg November 21, 2019 22:14
c0bw3b
c0bw3b approved these changes Nov 24, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

Result of nix-review pr 73882 1

1 package were build:
  • tnef

@c0bw3b c0bw3b merged commit b9d458d into NixOS:master Nov 24, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 24, 2019

@risicle I'm backporting it

c0bw3b pushed a commit that referenced this pull request Nov 24, 2019
@risicle @c0bw3b
tnef: 1.4.17 -> 1.4.18 (security)
753a1ac 
Backport of #73882

addresses CVE-2019-18849

(cherry picked from commit b9d458d)
c0bw3b pushed a commit that referenced this pull request Nov 24, 2019
@risicle @c0bw3b
tnef: 1.4.17 -> 1.4.18 (security)
2ddaccb 
Backport of #73882
addresses CVE-2019-18849

(cherry picked from commit b9d458d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @c0bw3b