Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib.setupHook: fix make_glib_find_gsettings_schemas #73881

Merged
merged 1 commit into from Nov 22, 2019
Merged

glib.setupHook: fix make_glib_find_gsettings_schemas #73881

merged 1 commit into from Nov 22, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 21, 2019 •
edited

Motivation for this change

GSETTINGS_SCHEMAS_PATH needs to contain a list of directories containing glib-2.0/schemas. 770a4c7 broke that by accidentally adding glib-2.0 to the paths.

This needs to go to master because it is blocking channels via gnome3 tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@jtojnar
glib.setupHook: fix make_glib_find_gsettings_schemas
1c9ba9f 
GSETTINGS_SCHEMAS_PATH needs to contain a list of directories containing glib-2.0/schemas.
770a4c7 broke that by accidentally adding glib-2.0 to the paths.
@jtojnar jtojnar added the 1.severity: channel blocker Blocks a channel label Nov 21, 2019
@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 22, 2019

Seems to have fixed the paths.

@jtojnar jtojnar merged commit c589f70 into NixOS:master Nov 22, 2019
@jtojnar jtojnar deleted the glib-fix-hook branch November 22, 2019 00:37
@worldofpeace
Copy link
Contributor

Yeah, this was a pretty bad regression...

Thanks for fixing this quickly @jtojnar 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @worldofpeace