Cleanup release.nix and setup.py; bump to 19.09 in CI #18
Conversation
- Use pname - Consistent formatting and indentation - Better meta description - Use substituteAllInPlace - Cleanup setup.py - Use 19.09 channel in Travis CI No real functional change.
|
Actually, I don't see any Travis builds on any PRs; is there actually CI for this repo? |
| for i in setup.py; do | ||
| substituteInPlace $i --subst-var-by version ${version} | ||
| done | ||
| substituteAllInPlace setup.py |
There was a problem hiding this comment.
this lacks --subst-var-by version ${version} right ?
There was a problem hiding this comment.
substituteAllInPlace replaces every instance of @foo@ with the value of $foo, if set. Since version is set this does the same thing in less code. If in doubt we can add a cat setup.py at the end of our patch phase to verify:
λ brh nixops-aws → nix-build release.nix -A build.x86_64-linux
these derivations will be built:
/nix/store/ajy200czzl0f8wbsqzb1j14fcl9dmlaq-nixops-aws-1.7pre0_abcdef.drv
building '/nix/store/ajy200czzl0f8wbsqzb1j14fcl9dmlaq-nixops-aws-1.7pre0_abcdef.drv'...
...
patching sources
from distutils.core import setup
setup(name='nixops-aws',
version='1.7pre0_abcdef',
description='NixOS cloud deployment tool, but for aws',
url='https://github.com/NixOS/nixops-aws',
# TODO: add author
author='',
author_email='',
packages=['nixopsaws', 'nixopsaws.data', 'nixopsaws.resources', 'nixopsaws.backends'],
entry_points={'nixops': ['aws = nixopsaws.plugin']},
py_modules=['plugin']
)
configuring
no configure script, doing nothing
building
...
There was a problem hiding this comment.
great, I didn't know that. Thanks
Yeah I don't think we did the Travis setup for the individual plugin repos |
|
It's an orthogonal change to this PR, but it might be nice to turn Travis CI (or some other equivalent CI setup) on PRs to validate the basics, at least. |
No real functional change.