Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update packages I maintain #73869

Merged
merged 8 commits into from Nov 21, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Not in need of review, will merge once CI succeeds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a failure:

builder for '/nix/store/6adr4ipknp5yxv2ynx602vngxp9iz6yp-qgnomeplatform-0.6.0.drv' failed with exit code 2; last 10 log lines:
  substituteStream(): WARNING: pattern '$$[QT_INSTALL_PLUGINS]' doesn't match anything in file 'qgnomeplatform.pro'
  configuring
  QMAKEPATH=/nix/store/1j6sp2ljxl5m9731aghpydsn3cppvcpl-qtbase-5.12.5-dev:/nix/store/1j6sp2ljxl5m9731aghpydsn3cppvcpl-qtbase-5.12.5-dev:/nix/store/7b7cfyb6pa8bmlgjiwf5kflys8v5p0xw-qtwayland-5.12.5-dev:/nix/store/7b7cfyb6pa8bmlgjiwf5kflys8v5p0xw-qtwayland-5.12.5-dev:/nix/store/2494zw607f4l1qclvv4p5cvzx9rvwpz1-qtdeclarative-5.12.5-dev:/nix/store/2494zw607f4l1qclvv4p5cvzx9rvwpz1-qtdeclarative-5.12.5-dev:/nix/store/34dc2km0nxrsrxczbyfgmddz8ibbsdng-qtsvg-5.12.5-dev:/nix/store/34dc2km0nxrsrxczbyfgmddz8ibbsdng-qtsvg-5.12.5-dev
  qmake PREFIX=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_OUT=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_DEV=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_BIN=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_DOC=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0/share/doc/qt-5.12.5 NIX_OUTPUT_QML=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0/lib/qt-5.12.5/qml NIX_OUTPUT_PLUGIN=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0/lib/qt-5.12.5/plugins CONFIG+=release
  Info: creating stash file /build/source/.qmake.stash
  building
  build flags: -j24 -l24 SHELL=/nix/store/b34zjdmq5l8k6rwdykjx55yl9r9isl8k-bash-4.4-p23/bin/bash
  cd common/ && ( test -e Makefile || /nix/store/1j6sp2ljxl5m9731aghpydsn3cppvcpl-qtbase-5.12.5-dev/bin/qmake -o Makefile /build/source/common/common.pro PREFIX=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_OUT=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_DEV=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_BIN=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0 NIX_OUTPUT_DOC=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0/share/doc/qt-5.12.5 NIX_OUTPUT_QML=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0/lib/qt-5.12.5/qml NIX_OUTPUT_PLUGIN=/nix/store/dq6lmdm2g20ajadab0lvpk0hlrc5cg77-qgnomeplatform-0.6.0/lib/qt-5.12.5/plugins CONFIG+=release ) && make -f Makefile
  Project ERROR: Unknown module(s) in QT: x11extras
  make: *** [Makefile:49: sub-common-make_first] Error 3
cannot build derivation '/nix/store/wij6939pgkdd1qvs192r39vqmgz8a4kg-env.drv': 1 dependencies couldn't be built
[19 built (1 failed), 158 copied (454.8 MiB), 83.9 MiB DL]
error: build of '/nix/store/wij6939pgkdd1qvs192r39vqmgz8a4kg-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73869
1 package failed to build:
qgnomeplatform

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
didn't really test though

[2 built, 2 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73869
10 package were built:
adwaita-qt aesop ephemeral formatter ideogram meteo python27Packages.anytree python37Packages.anytree python38Packages.anytree qgnomeplatform

@worldofpeace
Copy link
Contributor Author

nix-review passes on NixOS
diff LGTM
commits LGTM
didn't really test though

[2 built, 2 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73869
10 package were built:
adwaita-qt aesop ephemeral formatter ideogram meteo python27Packages.anytree python37Packages.anytree python38Packages.anytree qgnomeplatform

Thanks for building it though 👍

@worldofpeace worldofpeace merged commit 96c374f into NixOS:master Nov 21, 2019
@worldofpeace worldofpeace deleted the updates-worldofpeace branch November 21, 2019 17:56
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 21, 2019
[CI] Update packages I maintain

(cherry picked from commit 96c374f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants