Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlab: 1.6.0 -> 1.7.0 #73839

Merged
merged 1 commit into from Nov 21, 2019
Merged

texlab: 1.6.0 -> 1.7.0 #73839

merged 1 commit into from Nov 21, 2019

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Nov 20, 2019 •
edited

Motivation for this change

Upgrade texlab from 1.6.0 to 1.7.0: https://github.com/latex-lsp/texlab/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @doronbehar

@ofborg ofborg bot requested a review from doronbehar November 20, 2019 23:02
jonringer
jonringer approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executable shows usage

[4 built, 3 copied (98.3 MiB), 15.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73839
1 package were built:
texlab

@jonringer
Copy link
Contributor

created issue about ducc dependency not being able to build on arm, SkylerLipthay/ducc#5

@jonringer jonringer merged commit f3402a3 into NixOS:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kira-bruneau @jonringer