Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

boohu: 0.12.0 -> 0.13.0 #73838

Merged
merged 1 commit into from Nov 20, 2019
Merged

boohu: 0.12.0 -> 0.13.0 #73838

merged 1 commit into from Nov 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 20, 2019

Motivation for this change

Boohu version update 馃懡

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md

@GrahamcOfBorg build boohu

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
game starts

[5 built, 2 copied (428.6 MiB), 102.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73838
1 package were built:
boohu

@jonringer jonringer merged commit f18e73c into NixOS:master Nov 20, 2019
@ghost
Copy link
Author

ghost commented Dec 1, 2019

@jonringer Thanks! 馃懡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant