Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidStudioPackages: 3.6.0-beta5 -> 3.6.0-rc1 #75924

Closed
wants to merge 1 commit into from
Closed

androidStudioPackages: 3.6.0-beta5 -> 3.6.0-rc1 #75924

wants to merge 1 commit into from

Conversation

alapshin
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @primeos

jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that nothing built on nix-review

Nothing changed
https://github.com/NixOS/nixpkgs/pull/75924
$ nix-shell /home/jon/.cache/nix-review/pr-75924/shell.nix

but it did build fine:

[nix-shell:/home/jon/.cache/nix-review/pr-75924]$ nix-build ./nixpkgs/ -A androidStudioPackages.beta
these derivations will be built:
  /nix/store/hb6c0x77cmd27c3bjj73bbk6yfvbyks3-android-studio-beta-3.6.0.18.drv
these paths will be fetched (641.72 MiB download, 1376.82 MiB unpacked):
  /nix/store/l2fwk8gsnkmaijbr0q31mscalpacd8pm-android-studio-beta-3.6.0.18-unwrapped
copying path '/nix/store/l2fwk8gsnkmaijbr0q31mscalpacd8pm-android-studio-beta-3.6.0.18-unwrapped' from 'https://cache.nixos.org'...
building '/nix/store/hb6c0x77cmd27c3bjj73bbk6yfvbyks3-android-studio-beta-3.6.0.18.drv'...
/nix/store/jnfc66dj9n583jjlrl4kvbnqzkj46brs-android-studio-beta-3.6.0.18

@primeos
Copy link
Member

primeos commented Dec 19, 2019

weird that nothing built on nix-review

That's because the update is already in master (I've pushed it directly yesterday): 4cccc3c
Unfortunately the GitHub UI shows the diff anyway in these cases.

@alapshin please let me know if you're interested in actively maintaining Android Studio (i.e. subscribing to the RSS-Feed and updating/testing the package). I don't use it anymore and it would be useful to have a maintainer that actively uses Android Studio and can e.g. also test the emulator.

@primeos primeos closed this Dec 19, 2019
@alapshin
Copy link
Contributor Author

@primeos

Oops, sorry didn't see 4cccc3c since I'm a couple of days behind on nixpkgs-unstable channel.

Please let me know if you're interested in actively maintaining Android Studio (i.e. subscribing to the RSS-Feed and updating/testing the package). I don't use it anymore and it would be useful to have a maintainer that actively uses Android Studio and can e.g. also test the emulator.

Sure, I can help in maintaining it (at least while I'm working with android), I'm not very experienced with Nix/Nixpkgs but package seems to be in good health and don't have a problem to update it from time to time or review/test other changes.

@alapshin alapshin deleted the android-studio-3.6-rc1 branch December 19, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alapshin @primeos @jonringer