Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spago: 0.12.1.0 -> 0.13.0 #76084

Merged
merged 2 commits into from Dec 21, 2019
Merged

spago: 0.12.1.0 -> 0.13.0 #76084

merged 2 commits into from Dec 21, 2019

Conversation

cdepillabout
Copy link
Member

Motivation for this change

Update spago to the latest release:

https://github.com/spacchetti/spago/releases/tag/0.13.0

This requires that haskellPackages.dhall_1_27_0 exists, which was added in #76081 but hasn't been generated yet.

When it gets generated, this PR can be rebased on top of haskell-updates and merged in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cdepillabout cdepillabout mentioned this pull request Dec 20, 2019
Closed
10 tasks
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build spago

@cdepillabout
Copy link
Member Author

Looks like it is successful on x86_64. I'll go ahead and merge in.

It looks like it is failing on darwin for some reason, but I don't have a mac machine here to test on. Maybe someone will notice this and try to fix it up.

@cdepillabout cdepillabout merged commit 70b2584 into NixOS:haskell-updates Dec 21, 2019
@cdepillabout cdepillabout deleted the update-spago-to-0.13.0 branch December 21, 2019 04:08
@simonchatts simonchatts mentioned this pull request Feb 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cdepillabout