Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-generate-config: don't generate swapDevices for zram devices #75921

Merged
merged 1 commit into from Dec 19, 2019
Merged

nixos-generate-config: don't generate swapDevices for zram devices #75921

merged 1 commit into from Dec 19, 2019

Conversation

buckley310
Copy link
Contributor

Motivation for this change

If I have a system running with zramSwap.enable=true, and then run nixos-generate-config and rebuild/switch, I end up with an fstab with duplicate entries for /dev/zram0.

If I then remove zramSwap.enable and rebuild/switch, /dev/zram0 still remains in hardware-configuration.nix, so the system now stalls during boot waiting for the non-existent device.

Things done

Tested on systems with zram, swap partition, and both. Only zram device was excluded from hardware-configuration.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst danbst merged commit ebbb716 into NixOS:master Dec 19, 2019
@danbst
Copy link
Contributor

danbst commented Dec 19, 2019

Thanks, I had noticed this problem some time ago, but somehow forgot about that.

@buckley310 buckley310 deleted the hardware-config-zram branch October 8, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buckley310 @danbst