New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with latest version of WebRTC spec #20832
Merged
caribouW3
merged 15 commits into
web-platform-tests:master
from
dontcallmedom:webrtc-cleanup
Sep 30, 2020
Merged
Align with latest version of WebRTC spec #20832
caribouW3
merged 15 commits into
web-platform-tests:master
from
dontcallmedom:webrtc-cleanup
Sep 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was trying to read the stats on the receiver using the track from the sender rather than the receiver
Also, use getTransceivers() rather than getReceivers() since stopped receivers aren't provided in getReceivers()
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
guidou,
henbos,
jan-ivar,
rwaldron,
snuggs and
youennf
December 18, 2019 14:11
dontcallmedom
added a commit
to w3c/webrtc-interop-reports
that referenced
this pull request
Dec 18, 2019
Reflect pending pull request to WPT re test bugs web-platform-tests/wpt#20832
This was referenced Dec 18, 2019
caribouW3
approved these changes
Sep 30, 2020
ziransun
pushed a commit
to ziransun/wpt
that referenced
this pull request
Oct 6, 2020
* Remove test for getDefaultIceServers which is no longer in the WebRTC spec * Remove unneeded dependency on getUserMedia for testing WebRTC stats * Fix bug in reading stats on receiver The test was trying to read the stats on the receiver using the track from the sender rather than the receiver * Remove obsolete RTCMediaStreamStats tests * Align with latest set of mandatory to implement stats From https://w3c.github.io/webrtc-pc/webrtc.html#mandatory-to-implement-stats * Remove test for obsolete 'stream' stats * Remove RTCRtpParameters features removed from the spec * Align with removal of encodings as receiverparameters Also, use getTransceivers() rather than getReceivers() since stopped receivers aren't provided in getReceivers() * encodings is only for SenderParameters now * Align with specs on content of rtpencoding parameters * Remove abandonned datachannel priority attribute * Align with removal of rtcoauthcredential * Remove test for obsoleted RTCMediaStreamStats * Align with latest MTI stats hiearchy based on https://w3c.github.io/webrtc-pc/webrtc.html#mandatory-to-implement-stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest CR of WebRTC removes a number of features which this pull request reflects on the relevant test suite. It also fixes a couple of small bugs.