Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates poetry, cachy, and clikit #75873

Closed
wants to merge 3 commits into from
Closed

Updates poetry, cachy, and clikit #75873

wants to merge 3 commits into from

Conversation

robertodr
Copy link
Contributor

@robertodr robertodr commented Dec 18, 2019 •
edited

Motivation for this change

Updates the pyrsistent poetry, cachy, and clikit Python packages to their latest released versions on PyPI

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jbaum98 @desiderius

@ofborg ofborg bot requested a review from jbaum98 December 18, 2019 14:20
@robertodr robertodr mentioned this pull request Dec 18, 2019
Closed
10 tasks
@robertodr robertodr changed the title Updates pyrsistent, cachy, and clikit Updates poetry, cachy, and clikit Dec 19, 2019
@Br1ght0ne
Copy link
Member

@GrahamcOfBorg build python3Packages.poetry python3Packages.cachy python3Packages.clikit

Br1ght0ne
Br1ght0ne approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
checked poetry with nix-review

@jonringer
Copy link
Contributor

i think these are included in #76059

@robertodr
Copy link
Contributor Author

robertodr commented Dec 20, 2019 •
edited

Yes, cachy and clikit are included. I'll keep an eye on that PR and then rebase once it's been merged. Is there a way to mark this PR as "on hold"?

@adisbladis
Copy link
Member

Top-level poetry was bumped in #76646, though this still leaves python3Packages.poetry at 0.12.17.

@robertodr
Copy link
Contributor Author

Closing as all packages were updated in other PRs (#76059 and #76646)

@robertodr robertodr closed this Jan 5, 2020
@robertodr robertodr deleted the pyupdates branch April 23, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robertodr @Br1ght0ne @jonringer @adisbladis