ripgrep-all: add missing dependencies #75874
Conversation
This change adds additional dependencies so that the program's full functionality is available by simply installing this package. Closes NixOS#75735
This change adds a checkInstallPhase which runs a couple of queries to smoke-test the ripgrep-all adapters. The queries are intended to ensure that the dependencies needed by the adapters are included in the package's dependencies.
|
This way there's no opt-out from tesseract or imagemagick, right? We could merge this and I could open another PR where we also add support for (en/dis)abling those. |
|
Yes, that's correct. This change makes tesseract and imagemagick required dependencies. I noticed that the Rust development environment is quite large (~500 MB download) and that the Rust dependencies are built in a temporary environment, meaning they are not cached in the Nix store. Thus I think using only optional parameters for tesseract and imagemagick would cause the user to have to download the Rust dev environment and built all of the dependencies; It takes a while ;) One approach is to have a separate package, and another is to follow in the footsteps of, say, the firefox package, and provide an unwrapped version of the package. That way, the bulk of the work would be done by Hydra and users would only end up installing a wrapper, which would build quickly by comparison. Either way, when tesseract and imagemagick are excluded, the |
Motivation for this change
This change adds additional dependencies so that the program's full functionality is available by simply installing this package.
In addition, a second commit adds a checkInstallPhase which runs a couple of queries to smoke-test the ripgrep-all adapters. The queries are intended to ensure that the dependencies needed by the adapters are included in the package's dependencies.
Closes #75735
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after):Before: 2,620,416,224
After: 3,792,946,536
Notify maintainers
cc @zaninime