Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wooting: init wootility, wooting-udev-rules and module #75940

Merged
merged 3 commits into from Mar 22, 2020
Merged

wooting: init wootility, wooting-udev-rules and module #75940

merged 3 commits into from Mar 22, 2020

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Dec 19, 2019 •
edited

Motivation for this change

Adds support for Wooting keyboards, including Wootility package, udev rules package and hardware.wooting module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc me!

matthewbauer
matthewbauer reviewed Dec 19, 2019
View reviewed changes
pkgs/os-specific/linux/wooting-udev-rules/default.nix
pname = "wooting-udev-rules";
version = "20190601";

src = [ ./wooting.rules ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an external url for this that would be updated when for instance a new model is released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment with the source of the rules.

@davidtwco
wooting-udev-rules: init at 20190601
4a08198 
Signed-off-by: David Wood <david.wood@codeplay.com>
@davidtwco
wootility: init at 3.3.3
47d402e 
Signed-off-by: David Wood <david.wood@codeplay.com>
@davidtwco
nixos/wooting: add hardware.wooting module
33f4d93 
Signed-off-by: David Wood <david.wood@codeplay.com>
@davidtwco
Copy link
Member Author

@matthewbauer Is there anything I can do to help see this land?

@matthewbauer matthewbauer merged commit b943009 into NixOS:master Mar 22, 2020
@davidtwco davidtwco deleted the wooting-init branch March 31, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @matthewbauer