New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: semantic HTML-elements for the pages main sections #113
Conversation
Building the website failed in the test because of an error, thrown in fetch-downloads.py (returned a non-zero code: 1). I didn't touch fetch-downloads.py and don't know how to handle the error. Any advice? |
It's the usual random failure of downloads |
Oh nice now the farm is totally broken. Seems to be a ruby update from yesterday. |
Please rebase; that should fix the checks :) |
You mean I should rebase my branch including your change of #114 following i.e. these instructions? Is that correct? |
That would have the effect of retriggering the CI, yes |
…ding CSS-rules Further changes: - remove background.png (replaced with CSS background-color) - replace class name 'right' with 'further-link' because 'right' is based on the current optical represantation and with a change of that …
Yeah! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presuming removing background.png won't have a knock-on affect for the sub-sites not hosting their own...
Ha! I didn't check that. ... As far as I can see, it is The main page inserts the image directly from the domain www.openttd.org (https://www.openttd.org/static/img/layout/background.png). It might be possible that one is a link to the other source on the file system of the server. But that's something I can't check. ;-) |
This repository is fully separate from the rest of the infrastructure. This includes reuse of images etc ;) We used to host all images on media.openttd.org indeed (back in the days that was normal :P). So all the old infrastructure still uses that. So yeah, this should be save to use :) Good analysis ;) |
https://www.staging.openttd.org/ Screenshot on the homepage is aligned wrong now :( Not sure what went wrong :D |
Is this cleared with #121? |
Indeed, should be fine now |
Thank you for the clarification. It's nice to see so many small but effectfull changes that followed during the last days. 👍 |
… and corresponding CSS-rules
Further changes:
This is my third attempt to create an overhauled structure of the main page elements. After waiting for over a half year for the motivation to finish the work in #84 and struggling with importing the changes of the last seven months I decided to cherry-pick the old changes into a new branch and to finish the work on the requested change. I hope, these are all necessary parts.