Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 10.17.0 -> 10.18.0, 12.13.1 -> 12.14.0 #75887

Merged
merged 2 commits into from Dec 18, 2019
Merged

nodejs: 10.17.0 -> 10.18.0, 12.13.1 -> 12.14.0 #75887

merged 2 commits into from Dec 18, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 18, 2019

Motivation for this change

See: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam changed the title nodejs: 10.17.0 -> 10.18.0, 12.13.1 -> 12.14.0, 13.3.0 -> 13.5.0 nodejs: 10.17.0 -> 10.18.0, 12.13.1 -> 12.14.0 Dec 18, 2019
@marsam marsam merged commit 2a361e5 into NixOS:master Dec 18, 2019
@marsam marsam deleted the update-nodejs branch December 18, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marsam