Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vim-elm-syntax to vimPlugins #75905

Merged
merged 2 commits into from Dec 19, 2019
Merged

Add vim-elm-syntax to vimPlugins #75905

merged 2 commits into from Dec 19, 2019

Conversation

poliez
Copy link
Contributor

@poliez poliez commented Dec 18, 2019 •
edited by jonringer

Motivation for this change

This is the elm syntax package recommended here and, since i use coc-nvim, I'd prefer not to use elm-vim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from jorsn December 18, 2019 22:57
jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

[39 built, 33 copied (843.4 MiB), 193.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75905
20 package were built:
vimPlugins.coc-java vimPlugins.csv-vim vimPlugins.denite-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-go vimPlugins.deoplete-khard vimPlugins.deoplete-nvim vimPlugins.fzf-vim vimPlugins.nord-vim vimPlugins.typescript-vim vimPlugins.vim-airline vimPlugins.vim-airline-themes vimPlugins.vim-android vimPlugins.vim-dirvish vimPlugins.vim-elm-syntax vimPlugins.vim-go vimPlugins.vim-javacomplete2 vimPlugins.vim-lsc vimPlugins.vim-table-mode vimPlugins.vim-visual-multi

@jonringer jonringer merged commit 7af70d8 into NixOS:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poliez @jonringer @Janik-Haag