libspnav: init at 2.3.0 #75866

Sohalt · 2019-12-18T12:01:11Z

Motivation for this change

This adds libspnav and spacenavd to use 6DOF mice, such as the 3DConnexion SpaceNavigator.

Things done

Notify maintainers

cc @

Sohalt · 2019-12-18T12:02:35Z

Please tell me if I should split this into multiple pull requests.

pkgs/applications/misc/spacenav-cube-example/default.nix

pkgs/development/libraries/libspnav/default.nix

pkgs/misc/drivers/spacenavd/default.nix

pkgs/applications/misc/spacenav-cube-example/default.nix

pkgs/applications/misc/blender/default.nix

nixos/modules/services/hardware/spacenavd.nix

pkgs/applications/misc/spacenav-cube-example/default.nix

infinisil · 2019-12-25T15:35:48Z

Looking good now, only thing remaining is to clean up the history, with one initial commit for adding yourself as a maintainer, one commit for each package and one for the module

nixos/modules/services/hardware/spacenavd.nix

infinisil

Looking good from my side

infinisil · 2020-02-16T20:27:48Z

Can you rebase this instead of merging from master?

stale · 2020-10-31T13:56:13Z

I marked this as stale due to inactivity. → More info

Sohalt · 2020-10-31T14:39:28Z

Still relevant

pkgs/applications/misc/spacenav-cube-example/default.nix

pkgs/development/libraries/libspnav/default.nix

pkgs/misc/drivers/spacenavd/default.nix

pkgs/development/libraries/libspnav/configure-socket-path.patch

pkgs/misc/drivers/spacenavd/configure-socket-path.patch

pkgs/misc/drivers/spacenavd/default.nix

pkgs/applications/graphics/freecad/default.nix

pkgs/applications/misc/spacenav-cube-example/default.nix

pkgs/development/libraries/libspnav/default.nix

pkgs/misc/drivers/spacenavd/default.nix

flokli

A little nit, otherwise LGTM. I can't really test this currently, as I don't have access to the hardware currently.

pkgs/applications/graphics/freecad/default.nix

pkgs/applications/misc/spacenav-cube-example/default.nix

SuperSandro2000 · 2021-02-17T14:08:30Z

pkgs/development/libraries/libspnav/default.nix

@@ -0,0 +1,32 @@
+{ stdenv, lib, fetchFromGitHub, libX11}:


Suggested change

{ stdenv, lib, fetchFromGitHub, libX11}:

{ stdenv, lib, fetchFromGitHub, libX11 }:

pkgs/misc/drivers/spacenavd/default.nix

SuperSandro2000 · 2021-02-17T14:30:12Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 75866 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

3 packages built:

libspnav
spacenav-cube-example
spacenavd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

libspnav:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/libspnav/default.nix:16:15:

   |
16 |   patches = [ ./configure-socket-path.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

spacenav-cube-example:

installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/applications/misc/spacenav-cube-example/default.nix:15:3:

   |
15 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

spacenavd:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/misc/drivers/spacenavd/default.nix:16:15:

   |
16 |   patches = [ ./configure-socket-path.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

SuperSandro2000

other than that LGTM

pkgs/applications/graphics/freecad/default.nix

SuperSandro2000 · 2021-02-19T18:10:47Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 75866 run on x86_64-darwin 1

3 packages failed to build and already failed to build on hydra master:

libspnav: plain log | pretty log
spacenav-cube-example: log was empty
spacenavd: plain log | pretty log

Sohalt · 2021-02-26T16:00:33Z

Thanks to everyone who helped review this!

Sohalt requested a review from infinisil as a code owner December 18, 2019 12:01

Sohalt changed the title ~~Spnav~~ libspnav: init at 2.3.0 Dec 18, 2019

ofborg bot added 6.topic: nixos 8.has: module (update) labels Dec 18, 2019

ajs124 requested changes Dec 18, 2019

View reviewed changes

Sohalt force-pushed the spnav branch from a104a06 to f3768be Compare December 18, 2019 13:46

ofborg bot added the 8.has: package (new) label Dec 18, 2019

ofborg bot requested a review from cillianderoiste December 18, 2019 13:55

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 18, 2019

Sohalt force-pushed the spnav branch from ae5e583 to 72ae0c5 Compare December 18, 2019 15:31

ofborg bot added the 11.by: package-maintainer label Dec 18, 2019

infinisil requested changes Dec 24, 2019

View reviewed changes

nixos/modules/services/hardware/spacenavd.nix Outdated Show resolved Hide resolved

pkgs/applications/misc/spacenav-cube-example/default.nix Show resolved Hide resolved

jtojnar reviewed Dec 25, 2019

View reviewed changes

nixos/modules/services/hardware/spacenavd.nix Outdated Show resolved Hide resolved

Sohalt force-pushed the spnav branch from 3bd9188 to 8041e53 Compare December 29, 2019 16:54

Sohalt requested a review from infinisil January 3, 2020 20:59

Sohalt force-pushed the spnav branch from 8041e53 to 9d58bd8 Compare January 3, 2020 21:42

infinisil approved these changes Jan 4, 2020

View reviewed changes

Sohalt force-pushed the spnav branch from aaa4f0a to 95c2f20 Compare February 16, 2020 20:46

alyssais added the 2.status: merge conflict label Apr 2, 2020

Sohalt force-pushed the spnav branch from 95c2f20 to f7e0757 Compare May 4, 2020 13:43

ofborg bot removed the 2.status: merge conflict label May 4, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 31, 2020

SuperSandro2000 reviewed Nov 25, 2020

View reviewed changes

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 25, 2020

flokli reviewed Jan 25, 2021

View reviewed changes

Sohalt force-pushed the spnav branch from 546f452 to c972886 Compare February 2, 2021 21:09

ofborg bot added the 2.status: merge conflict label Feb 2, 2021

flokli reviewed Feb 2, 2021

View reviewed changes

pkgs/misc/drivers/spacenavd/configure-socket-path.patch Show resolved Hide resolved

jtojnar reviewed Feb 2, 2021

View reviewed changes

pkgs/misc/drivers/spacenavd/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 requested changes Feb 3, 2021

View reviewed changes

Sohalt force-pushed the spnav branch 2 times, most recently from 4db7376 to 710fe1a Compare February 4, 2021 22:50

ofborg bot removed the 2.status: merge conflict label Feb 4, 2021

Sohalt force-pushed the spnav branch from 710fe1a to b945c71 Compare February 4, 2021 22:56

Sohalt force-pushed the spnav branch from b945c71 to b0fb832 Compare February 15, 2021 15:33

ofborg bot requested review from gebner and viric February 15, 2021 15:43

flokli reviewed Feb 15, 2021

View reviewed changes

pkgs/applications/graphics/freecad/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 requested changes Feb 17, 2021

View reviewed changes

Sohalt added 5 commits February 18, 2021 15:08

libspnav: init at 0.2.3

373c6ad

spacenavd: init at 0.8

4f19003

nixos/spacenavd: init

725966b

spacenav-cube-example: init at 2.3.0

ea15465

blender: support for libspnav

e7933dd

Sohalt force-pushed the spnav branch from b0fb832 to adb7a72 Compare February 18, 2021 14:08

SuperSandro2000 approved these changes Feb 19, 2021

View reviewed changes

pkgs/applications/graphics/freecad/default.nix Outdated Show resolved Hide resolved

FreeCAD: add spacenav support

455cb9f

Sohalt force-pushed the spnav branch from adb7a72 to 455cb9f Compare February 26, 2021 15:58

Sohalt requested a review from ajs124 February 26, 2021 16:00

flokli merged commit 43f83f9 into NixOS:master Feb 26, 2021

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libspnav: init at 2.3.0 #75866

libspnav: init at 2.3.0 #75866

Sohalt commented Dec 18, 2019

Sohalt commented Dec 18, 2019

infinisil commented Dec 25, 2019

infinisil left a comment

infinisil commented Feb 16, 2020

stale bot commented Oct 31, 2020

Sohalt commented Oct 31, 2020

flokli left a comment

SuperSandro2000 Feb 17, 2021

SuperSandro2000 commented Feb 17, 2021

SuperSandro2000 left a comment

SuperSandro2000 commented Feb 19, 2021

Sohalt commented Feb 26, 2021

	{ stdenv, lib, fetchFromGitHub, libX11}:
	{ stdenv, lib, fetchFromGitHub, libX11 }:

libspnav: init at 2.3.0 #75866

libspnav: init at 2.3.0 #75866

Conversation

Sohalt commented Dec 18, 2019

Motivation for this change

Things done

Notify maintainers

Sohalt commented Dec 18, 2019

infinisil commented Dec 25, 2019

infinisil left a comment

Choose a reason for hiding this comment

infinisil commented Feb 16, 2020

stale bot commented Oct 31, 2020

Sohalt commented Oct 31, 2020

flokli left a comment

Choose a reason for hiding this comment

SuperSandro2000 Feb 17, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Feb 17, 2021

SuperSandro2000 left a comment

Choose a reason for hiding this comment

SuperSandro2000 commented Feb 19, 2021

Sohalt commented Feb 26, 2021