glirc: init at 2.33.1 #75945
Merged
glirc: init at 2.33.1 #75945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kiwi Thanks for this PR. Could you rebase this on top of the Also, if you'd like this to never be marked broken, you can add yourself as a maintainer for this package: We would expect you to fix up |
I believe to have done this properly now. Though the tests are failing so I'm not sure what's going on. |
haskellPackages.glirc is a "Console IRC Client." I've added a doJailbreak to fix the build (thanks @infinisil) and added it to top-level/all-packages.nix so people can find and install it as they would normally. Would be nice to make this build in a way that allows the OTR extension to be enabled. One thing at a time....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haskellPackages.glirc is a "Console IRC Client." I've added a doJailbreak
to fix the build (thanks @infinisil) and added it to top-level/all-packages.nix
so people can find and install it as they would normally.
Would be nice to make this build in a way that allows the OTR extension to be
enabled. One thing at a time....
Motivation for this change
glirc2 is my favorite IRC client and I'd like it to be easier to install and for it to stop being marked broken. :(
It has an OTR extension that I'd like to enable but I'm not sure how to yet. Right now getting it as a regular package that can build is a good start.
Things done
Added doJailbreak to glirc to make it build. Removed glirc from the yaml list of failing builds. Added glirc to all-packages.nix
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @