New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #75929
Merged
Merged
Staging next #75929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never used in the recent history.
* format with nixpkgs-fmt * drop unneeded dependencies * gnome-doc-utils → yelp-tools since 3.6.0 * intltool → gettext since 3.16.2 * move build-time deps to nativeBuildInputs * add metadata
It is a runtime dependency that produces dependency loop: anytree → graphviz → pango → glib → gtk-doc → anytree
* use buildPythonApplication instead of symlinking * but do not propagate Python * Add lxml & anytree for gtkdoc-mkhtml2
We are dropping Python support from gamin so nothing is holding us any more. Instead of gamin, we will use systemd on Linux and polling on Darwin; gamin is the worst backend any way, according to upstream: fail2ban/fail2ban#1330 (comment)
They are not compatible with Python 3, upstream as dead, and nothing uses the bindings any more. This is a progress in getting rid of Python 2 from closures of most people (samba, which depends on gamin shared library is common dependency).
Python is only used for a single console test these dayls and it likely requires non-trivial introspection hacks.
Also move the build-time dependencies to nativeBuildInputs, and drop perl as it no longer seems to be necessary (CMake is not looking for it any more).
Nothing was using them. Another step in Python 2 removal.
This improves build times significantly, from 20min to 9min on the aarch64 community box.
Borrowing fedora's 2to3 trick: https://src.fedoraproject.org/rpms/GConf2/blob/master/f/GConf2.spec#_90 (thank you, worldofpeace!)
FRidh
requested review from
jonringer,
LnL7,
Mic92 and
ttuegel
as code owners
December 19, 2019 08:32
ofborg
bot
added
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: python
6.topic: qt/kde
6.topic: rust
8.has: documentation
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Dec 19, 2019
We recently defaulted fontforge to python3 which made the python2 used by the build system unable to find fontforge.
Update, clean up and also fix build. Part of the build system still does not support Python 2: hakatashi/RictyDiminished-with-FiraCode#3
Fix services.xserver.extraLayouts under GNOME 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: nixos
6.topic: python
6.topic: qt/kde
6.topic: rust
8.has: documentation
8.has: module (update)
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @