Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #75929

Merged
merged 52 commits into from Dec 30, 2019
Merged

Staging next #75929

merged 52 commits into from Dec 30, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 19, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

It was never used in the recent history.
* format with nixpkgs-fmt
* drop unneeded dependencies
    * gnome-doc-utils → yelp-tools since 3.6.0
    * intltool → gettext since 3.16.2
* move build-time deps to nativeBuildInputs
* add metadata
It is a runtime dependency that produces dependency loop:

    anytree → graphviz → pango → glib → gtk-doc → anytree
* use buildPythonApplication instead of symlinking
   * but do not propagate Python
* Add lxml & anytree for gtkdoc-mkhtml2
We are dropping Python support from gamin so nothing is holding us any more.
Instead of gamin, we will use systemd on Linux and polling on Darwin;
gamin is the worst backend any way, according to upstream:

fail2ban/fail2ban#1330 (comment)
They are not compatible with Python 3, upstream as dead, and nothing uses the bindings any more.

This is a progress in getting rid of Python 2 from closures of most people (samba, which depends on gamin shared library is common dependency).
Python is only used for a single console test these dayls and it likely requires
non-trivial introspection hacks.
Also move the build-time dependencies to nativeBuildInputs, and drop perl as it no longer seems to be necessary (CMake is not looking for it any more).
Nothing was using them.

Another step in Python 2 removal.
FRidh and others added 4 commits December 19, 2019 09:21
This improves build times significantly, from 20min to 9min on the
aarch64 community box.
jtojnar and others added 7 commits December 25, 2019 05:15
We recently defaulted fontforge to python3 which made the python2 used by the build system unable to find fontforge.
Update, clean up and also fix build.

Part of the build system still does not support Python 2:

hakatashi/RictyDiminished-with-FiraCode#3
Fix services.xserver.extraLayouts under GNOME 3
@FRidh FRidh merged commit 9bc8e54 into master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants